Conversation
|
When we paired it was consciously decided that umd isn't useful to us anymore. Is satisfying what a |
|
We could omit the |
|
Something to look forward to is Node's experimental support for a It looks like producing UMD output is fairly easy to do with command line overrides to |
muan
left a comment
There was a problem hiding this comment.
I don’t have strong opinions against this. Feel free to carry on. Not sure why the tests are failing though.
koddsson
left a comment
There was a problem hiding this comment.
This looks good to me 🎇
test/karma.config.js
Outdated
| }, | ||
| 'test.js' | ||
| ], | ||
| files: ['bootstrap.js', '../dist/umd/index.js', 'test.js'], |
There was a problem hiding this comment.
bootstrap.js seems like an over-complication in comparison to loading the native module. Can we keep the test using the module output here?
I did not notice in #15 but that PR ended up producing a build that only included ES modules.
The
mainkey in a package.json should not be used for files that produce es modules. We should instead produce aumdcompatible bundle, and linkmainto that.This PR changes the
buildstep to produce bothusmandesstyle modules, and changes themainkey to point to theumdbuild.