Fix: Pasting of html with similar matches that have links#88
Fix: Pasting of html with similar matches that have links#88keithamus merged 3 commits intogithub:mainfrom
Conversation
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Primer first responder will review it soon.
|
keithamus
left a comment
There was a problem hiding this comment.
This looks like a great change, and thanks very much for adding tests!
I think this might be a good opportunity to look at our current tests and add a lot more robustness to them. It's non-obvious from the outset as to why this change causes such as behavioural change, and looking at the existing test suite, I'm not filled with confidence that this wouldn't introduce a regression somewhere (especially around dropping the else clause).
I'm happy for this PR to be merged and shipped but if you have some extra time I think it could be great to add some additional tests of various input where there may be edge cases.
I have added a few more tests related to links. I think we can keep an eye on the changes and see if there is more regression....is there a way to test before shipping? |
|
Thanks for adding these! We could make this a mode (i.e. add an option to enable the code path) and ship it as a feature flag in dotcom, but I don't think that'll be necessary. If it regresses we can revert and add more testing. |
Hi 👋🏼, this is an attempt to fix the issue below where Pasting HTML with links can place the link in the wrong place
The original fix was submitted here. This PR attempts to look at a few edge cases that came up as shown indicated in the issue above. These include:
and