exports option for es output is redundant. auto is best

jasonkarns · jasonkarns · commit d00a7fd5de56 · 2020-05-05T13:45:39.000-04:00
diff --git a/packages/optimizely-sdk/rollup.config.js b/packages/optimizely-sdk/rollup.config.js
@@ -22,30 +22,25 @@ import resolve from '@rollup/plugin-node-resolve';
 import visualizer from 'rollup-plugin-visualizer';
 import { dependencies } from './package.json';
 
-const BUILD_ALL = process.env.BUILD_ALL ? true : false;
-const BUILD_UMD_BUNDLE = process.env.BUILD_UMD_BUNDLE ? true : false;
-
-const cjsBuildFor = (platform) => {
-  return {
-    plugins: [
-      resolve(),
-      commonjs(),
-    ],
-    external: ['https', 'http', 'url'].concat(Object.keys(dependencies || {})),
-    input: `lib/index.${platform}.js`,
-    output: {
-      exports: 'named',
-      format: 'cjs',
-      file: `dist/optimizely.${platform}.min.js`,
-      plugins: [ terser() ]
-    }
-  };
-};
+const cjsBuildFor = (platform) => ({
+  plugins: [
+    resolve(),
+    commonjs(),
+    visualizer(),
+  ],
+  external: ['https', 'http', 'url'].concat(Object.keys(dependencies || {})),
+  input: `lib/index.${platform}.js`,
+  output: {
+    exports: 'named',
+    format: 'cjs',
+    file: `dist/optimizely.${platform}.min.js`,
+    plugins: [ terser() ]
+  }
+});
 
 const esmBundle = {
   ...cjsBuildFor('browser'),
   output: {
-    exports: 'named',
     format: 'es',
     file: 'dist/optimizely.browser.es.min.js',
     plugins: [ terser() ]
