Swap RST's use of object for SVG to use image
#287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Are we showing SVGs at all? I thought we blocked those for security reasons. |
Contributor
Author
|
@ymendel Oh we most certainly are showing them: https://github.com/gjtorikian/testing/blob/master/images.rst Travis and other services provide the SVG option alongside PNG. We're just blocking the N.B. In 7a9da18 I just let all the attributes get applied to |
Contributor
|
@gjtorikian: Ah, I've not kept up with the conversation, apparently. 🆒 I think applying all the attributes and letting the sanitizer deal with them is probably the right way to go. |
Contributor
|
👍 👍 Looks great. |
gjtorikian
added a commit
that referenced
this pull request
Apr 16, 2014
Swap RST's use of `object` for SVG to use `image`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264.
Similar to #256, the trick here was to look at the RST generation code and figure out how to override the method to do what we need it to do.
We're plucking attributes off theobjectand applying them to theimage. These attributes might seem somewhat arbitrary at first:* src* alt* width* heightThe original code also calls forEdit: this is no longer true, see below.style,class,align, etc., but we strip these out with sanitization anyway./cc @bkeepers @github/user-content @github/prose Which team is best pinged for these sorts of issues?