ALSA: seq: Remove superfluous snd_seq_queue_client_leave_cells() call

tiwai · tiwai · commit 85d59b57be59 · 2018-03-08T12:06:07.000+01:00
With the previous two fixes for the write / ioctl races:
  ALSA: seq: Don't allow resizing pool in use
  ALSA: seq: More protection for concurrent write and ioctl races
the cells aren't any longer in queues at the point calling
snd_seq_pool_done() in snd_seq_ioctl_set_client_pool().  Hence the
function call snd_seq_queue_client_leave_cells() can be dropped safely
from there.

Suggested-by: Nicolai Stange &lt;nstange@suse.de&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c
@@ -1846,7 +1846,6 @@ static int snd_seq_ioctl_set_client_pool(struct snd_seq_client *client,
 				return -EBUSY;
 			/* remove all existing cells */
 			snd_seq_pool_mark_closing(client->pool);
-			snd_seq_queue_client_leave_cells(client->number);
 			snd_seq_pool_done(client->pool);
 		}
 		client->pool->size = info->output_pool;

Original file line number	Diff line number	Diff line change
`@@ -1846,7 +1846,6 @@ static int snd_seq_ioctl_set_client_pool(struct snd_seq_client *client,`
`1846`	`1846`	`return -EBUSY;`
`1847`	`1847`	`/* remove all existing cells */`
`1848`	`1848`	`snd_seq_pool_mark_closing(client->pool);`
`1849`		`- snd_seq_queue_client_leave_cells(client->number);`
`1850`	`1849`	`snd_seq_pool_done(client->pool);`
`1851`	`1850`	`}`
`1852`	`1851`	`client->pool->size = info->output_pool;`