Repository navigation
libogc: remove duplicate *.o and *.elf rules - #4942
Open
mangeshraut712 wants to merge 1 commit into
Open
mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change removes redundant ignore rules while retaining the effective patterns, and the review identifies no active issues.
No open issues 🎉
What changed in this PR
Removes duplicate *.o and *.elf ignore rules from the libogc template while preserving existing ignore behavior and aligning the Object files section with C.gitignore.
Changes:
- Removes the duplicate
*.orule. - Removes the redundant
*.elfrule from the Executables section. - Retains the single
*.oand*.elfrules under Object files.
| File | Description |
|---|---|
| community/libogc.gitignore | Removes duplicate *.o and *.elf ignore patterns without changing which files are ignored. |
Review effort: Lite (auto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
https://github.com/devkitPro/libogc
Reasons for making this change
community/libogc.gitignorelists*.otwice in the "Object files" section and*.elftwice (once under "Object files", once under "Executables"). The duplicates came in with 136e88c, which merged the C.gitignore rules into this template. This removes the second*.oand the*.elfunder "Executables", so the "Object files" section matchesC.gitignore, where*.elflives. The contribution guidelines ask for no duplicate rules.Nothing is ignored differently: I checked
a.o,b.elf,c.dolandd.binwithgit check-ignore -vagainst the edited file and all four are still ignored,*.oand*.elfnow by their single remaining rules.Links to documentation supporting these rule changes
*.elfis under "Object files")Merge and Approval Steps