fix(go-gitignore): prevent coverage.go files from being excluded#4776
Open
tdabasinskas wants to merge 1 commit intogithub:mainfrom
Open
fix(go-gitignore): prevent coverage.go files from being excluded#4776tdabasinskas wants to merge 1 commit intogithub:mainfrom
tdabasinskas wants to merge 1 commit intogithub:mainfrom
Conversation
The current `coverage.*` pattern includes `*.go` files as well. If you use `go vendor`, this causes the following files to be excluded: - `vendor/golang.org/x/text/internal/language/coverage.go` - `vendor/golang.org/x/text/language/coverage.go` This becomes a nightmare to troubleshoot why the local build works, yet a CI fails (as the files were not committed). Adding `!coverage.go` ensure that `*.go` files do not get accidentally excluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
The current
coverage.*pattern unintentionally matches*.gofiles. When using Go vendoring, this causes legitimate source files to be excluded from version control:vendor/golang.org/x/text/internal/language/coverage.govendor/golang.org/x/text/language/coverage.goThis leads to a particularly difficult-to-debug scenario where local builds succeed but CI pipelines fail due to missing vendored files that were never committed.
Adding
!coverage.goensures that Go source files are not accidentally excluded by thecoverage.*pattern.Links to documentation supporting these rule changes
go mod vendorIf this is a new template
N/A — This is a modification to an existing template.
Merge and Approval Steps