Skip to content
This repository was archived by the owner on Jan 31, 2019. It is now read-only.

Add Typetalk service#825

Merged
atmos merged 2 commits intogithub:masterfrom
dragon3:typetalk
Apr 20, 2014
Merged

Add Typetalk service#825
atmos merged 2 commits intogithub:masterfrom
dragon3:typetalk

Conversation

@dragon3
Copy link
Contributor

@dragon3 dragon3 commented Apr 7, 2014

Typetalk is a chat service like HipChat or Campfire.
https://typetalk.in

atmos
atmos reviewed Apr 7, 2014
View reviewed changes
lib/services/typetalk.rb Outdated
Copy link
Contributor

@atmos atmos Apr 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the contribution guidelines we don't accept new services that are based on the Service class anymore.

@atmos
Copy link
Contributor

atmos commented Apr 7, 2014

Feel free to reopen this once the code is updated.

@atmos atmos closed this Apr 7, 2014
@dragon3
Copy link
Contributor Author

dragon3 commented Apr 8, 2014

@atmos Thank you for your review.
I've fixed it on dragon3/github-services@330490a .
Could you please reopen this?

@dragon3
Copy link
Contributor Author

dragon3 commented Apr 9, 2014

Hi @atmos
I can't reopen this, so is it better that I create a new pull request?

@atmos
Copy link
Contributor

atmos commented Apr 9, 2014

I'm traveling right now but can take a look in a few days.

@atmos atmos reopened this Apr 9, 2014
@dragon3
Copy link
Contributor Author

dragon3 commented Apr 10, 2014

Thanks!
Have a nice travel.

@dragon3
Copy link
Contributor Author

dragon3 commented Apr 20, 2014

Hi!
Any update?
Please let me know if you have any questions or I should modify/update something.
Thanks.

atmos added a commit that referenced this pull request Apr 20, 2014
@atmos
Merge pull request #825 from dragon3/typetalk
4fafefc 
Add Typetalk service
@atmos atmos merged commit 4fafefc into github:master Apr 20, 2014
@atmos
Copy link
Contributor

atmos commented Apr 20, 2014

@dragon3 Yeah, it should be live tomorrow.

@dragon3
Copy link
Contributor Author

dragon3 commented Apr 21, 2014

@atmos Thanks! 👍

@dragon3
Copy link
Contributor Author

dragon3 commented Apr 22, 2014

@atmos I can't select this service on repository settings yet. When will it be live?

@dragon3
Copy link
Contributor Author

dragon3 commented Apr 23, 2014

Now I can use this service.
Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dragon3 @atmos