Add per-label is_suggestion and rationale to issue_write#2656
Open
iulia-b wants to merge 5 commits into
Open
Conversation
Extend the general issue_write tool so each label can be sent either as a plain name or as an object with optional rationale (<=280 chars) and is_suggestion. On update, labels with intent are sent in object form (mapping is_suggestion to suggest); the create path strips intent. Mirrors the granular update_issue_labels behavior.
alondahari
previously approved these changes
Jun 9, 2026
alondahari
left a comment
alondahari
left a comment
Member
There was a problem hiding this comment.
Looks good, just a comment about extensibility
boazreicher
reviewed
Jun 9, 2026
| }, | ||
| "rationale": { | ||
| Type: "string", | ||
| Description: "One concise sentence explaining what specifically about the issue led you to choose this label. " + |
Contributor
There was a problem hiding this comment.
Since the limit is 280, why do we want to say that it's limited to one sentance?
Contributor
|
@iulia-b what about confidence arguments? |
Extract a shared valueIntent struct plus parseValueIntent and intent schema helpers so rationale/confidence/is_suggestion can be reused across written values (labels now; issue types and field values in a future PR). Add confidence to issue_write labels, reword the rationale description, and generalize the is_suggestion wording.
Replace the granular labels tool's inline rationale/confidence/is_suggestion parsing with the shared parseValueIntent helper, removing the duplicate parser. Behavior is unchanged except the over-length rationale error now uses the shared message.
iulia-b
commented
Jun 10, 2026
| }, | ||
| { | ||
| "properties": { | ||
| "confidence": { |
Contributor
Author
There was a problem hiding this comment.
@boazreicher I added confidence with values low, medium and high, and without any optional param or anything special, just sending it to the server
iulia-b
commented
Jun 10, 2026
| {Type: "string", Description: "Label name"}, | ||
| { | ||
| Type: "object", | ||
| Properties: withIntentProperties(map[string]*jsonschema.Schema{ |
Contributor
Author
There was a problem hiding this comment.
@boazreicher @alondahari , I extracted the parser and also the intent related props in their own type, and using it to extend labels (and soon, types and field values) ; also using this in the issues_granular
iulia-b
commented
Jun 10, 2026
|
|
||
| // HasIntent reports whether any intent metadata was supplied. | ||
| func (v valueIntent) HasIntent() bool { | ||
| return v.Rationale != "" || v.Confidence != "" || v.Suggest |
Contributor
Author
There was a problem hiding this comment.
@boazreicher is this valid or should it only be v.Suggest == true for HasIntent?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the issue_write tool’s labels parameter to support per-label “intent” metadata (optional rationale and is_suggestion) by allowing each label entry to be either a plain string or an object, and updates the update path to preserve intent on the wire.
Changes:
- Updated
issue_writeJSON schema solabels[]supportsstringor{ name, rationale?, confidence?, is_suggestion? }. - Implemented update-time label intent propagation by sending a custom PATCH payload when intent is present.
- Refactored granular label update parsing/validation into shared helpers and updated toolsnaps/docs/tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| README.md | Regenerated docs reflecting the updated issue_write labels parameter shape. |
| pkg/github/issues.go | Adds label intent support to issue_write, extends UpdateIssue with an intent-aware labels path. |
| pkg/github/issues_test.go | Adds coverage for issue_write update requests that include label intent and validation errors. |
| pkg/github/issues_granular.go | Introduces shared “intent” parsing/schema helpers and reuses them in granular label updates. |
| pkg/github/granular_tools_test.go | Updates expected error messages to match the new shared intent validation. |
| pkg/github/toolsnaps/issue_write.snap | Updates tool schema snapshot for new labels union type and intent properties. |
| pkg/github/toolsnaps/issue_write_ff_remote_mcp_issue_fields.snap | Same schema snapshot update for the feature-flagged variant. |
| docs/insiders-features.md | Regenerated docs reflecting schema change. |
| docs/feature-flags.md | Regenerated docs reflecting schema change. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 3
Comment on lines
1858
to
1860
| Type: "array", | ||
| Description: "Labels to apply to this issue", | ||
| Items: &jsonschema.Schema{ |
Comment on lines
2146
to
2148
| Type: "array", | ||
| Description: "Labels to apply to this issue", | ||
| Items: &jsonschema.Schema{ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the general issue_write tool so each label can be sent either as a plain name or as an object with optional rationale (<=280 chars) and is_suggestion. On update, labels with intent are sent in object form (mapping is_suggestion to suggest); the create path strips intent. Mirrors the granular update_issue_labels behavior.
Summary
Why
Fixes https://github.com/github/plan-track-agentic-toolkit/issues/349
What changed
issue_writetool now supports labels suggestionsMCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs