Support referral chasing for Active Directory member validation #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 25, 2016 09:29
- Set empty search base in user? rather than in GitHub::Ldap - Get rid of indirection in Domain to global_catalog_search - Update test
added 2 commits
August 4, 2016 14:51
Contributor
Author
added 10 commits
August 4, 2016 18:17
test/referral_chaser_test.rb
Outdated
| admin_user: "Joe", | ||
| admin_password: "passworD1", | ||
| port: 389 | ||
| }) |
Member
There was a problem hiding this comment.
Want to use a mock here too? Or use the options hash to pull configuration for working connections?
test/referral_chaser_test.rb
Outdated
| admin_user: "uid=admin,dc=github,dc=com", | ||
| admin_password: "passworD1", | ||
| port: 389 | ||
| }) |
Member
There was a problem hiding this comment.
Still need to use the options defined in GitHub::Ldap::Test for the right host.
Note, though, that these failures are because capabilities are being checked to aggressively, causing a query to occur when creating a new object, rather than lazily loading the capabilities as needed. This is out-of-scope from this PR, but it's a constraint to getting the build to pass now.
Also use that port value, as it changes depending on the integration test LDAP server in use.
Stylistic preference to be more consistent with other tests.
Member
|
Looks like we're 🍏. Let's get this merged, @davesims. |
This was referenced Aug 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for chasing referrals during an Active Directory member validation. Added a
ReferralChaserobject that wrapsGitHub::Ldap#searchfunctionality with the ability to pursue any referred URLs that come back from the server. Will replace #91 and depends on #94./cc #94 #91
/cc @mtodd @jch @jatoben @lildude @sbryant
/cc @github/platform-iam