Expose Group.group? for testing if entry is a group #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtodd
added a commit
that referenced
this pull request
Dec 3, 2014
Expose Group.group? for testing if entry is a group
Contributor
|
@mtodd The class method makes sense to me since the method doesn't depend on any instance state. The |
Member
Author
|
@jch was tempted to make that change but decided to address that separately. I think you're right, though, it's way more useful like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal change to expose
GitHub::Ldap::Group.group?(entry)to check if theobjectClassmatches any known group types (group,groupOfNames,groupOfUniqueNames).cc @jch