Expand AD caps support to v60

mtodd · mtodd · commit e219da1cb86a · 2015-02-02T14:30:48.000-08:00
This adds support for Windows Server 2008 and above, instead of
only 2008 R2 and above.
diff --git a/lib/github/ldap.rb b/lib/github/ldap.rb
@@ -19,7 +19,7 @@ class Ldap
 
     # Internal: The capability required to use ActiveDirectory features.
     # See: http://msdn.microsoft.com/en-us/library/cc223359.aspx.
-    ACTIVE_DIRECTORY_V61_R2_OID = "1.2.840.113556.1.4.2080".freeze
+    ACTIVE_DIRECTORY_V60_OID = "1.2.840.113556.1.4.1935".freeze
 
     # Utility method to get the last operation result with a human friendly message.
     #
@@ -313,7 +313,7 @@ def configure_member_search_strategy(strategy = nil)
     #
     # Returns true if the host is an ActiveDirectory server, false otherwise.
     def active_directory_capability?
-      capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V61_R2_OID)
+      capabilities[:supportedcapabilities].include?(ACTIVE_DIRECTORY_V60_OID)
     end
     private :active_directory_capability?
   end
diff --git a/test/ldap_test.rb b/test/ldap_test.rb
@@ -80,7 +80,7 @@ def test_search_strategy_defaults
 
   def test_search_strategy_detects_active_directory
     caps = Net::LDAP::Entry.new
-    caps[:supportedcapabilities] = [GitHub::Ldap::ACTIVE_DIRECTORY_V61_R2_OID]
+    caps[:supportedcapabilities] = [GitHub::Ldap::ACTIVE_DIRECTORY_V60_OID]
 
     @ldap.stub :capabilities, caps do
       @ldap.configure_search_strategy :detect
