Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deploy command to exit with status code 1 on failures so that errors are propagated to the UI.
- Enforces
os.Exit(1)instead of returning silently on flag checks, directory errors, zip errors, API client errors, and deployment failures - Ensures a non-zero exit code for any CLI failure
- Centralizes failure behavior in
cmd/deploy.go
salvador-barboza
approved these changes
Jul 2, 2025
justinmcbride
approved these changes
Jul 2, 2025
jasonrclark
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For item: https://github.com/github/spark/issues/816. Exit on deploy failures so the error is propagated. The deploy script has
set eso it'll exit 1 if the cli command fails and show an error in the UI on deployment