Add runtime configuration support for deploy and get commands#17
Add runtime configuration support for deploy and get commands#17salvador-barboza merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds runtime configuration support for deploy and get commands, allowing users to use -c to read app name from config file instead of requiring a --app parameter. The implementation includes automatic fallback to runtime.config.json in the current directory when neither --app nor --config is specified.
Key changes:
- Created a new config package with reusable configuration reading functionality
- Updated deploy and get commands to support
-cflag for config file path - Added automatic detection of
runtime.config.jsonin current directory
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/config/config.go | New config package with RuntimeConfig struct and ReadRuntimeConfig function |
| cmd/init.go | Updated to use the new config package instead of local runtimeConfig struct |
| cmd/get.go | Added config flag support and automatic config file detection |
| cmd/deploy.go | Added config flag support and automatic config file detection |
| cmd/config.go | New file with duplicate config functionality (appears unused) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jasonrclark
left a comment
jasonrclark
left a comment
There was a problem hiding this comment.
Looks good. My Go is not strong, but is there a way to share the logic around the app name/config arg handling so we don't duplicate it between the commands? Feels like as we grow more commands, we'll just end up with more spots that this common behavior will pop up.
salvador-barboza
dismissed stale reviews from justinmcbride and jasonrclark
via
32a5ae9
3 participants
Allows using
-cto read app name from config file instead of requiring a--appparam