Skip to content

Mention that email drop-down menu only appears for more than one email#2835

Merged
janiceilene merged 4 commits intogithub:mainfrom
Andre601:patch-2
Mar 1, 2021
Merged

Mention that email drop-down menu only appears for more than one email#2835
janiceilene merged 4 commits intogithub:mainfrom
Andre601:patch-2

Conversation

@Andre601
Copy link
Copy Markdown
Contributor

@Andre601 Andre601 commented Jan 12, 2021 •
edited
Loading

Why:

I found this on the Docs page about Setting up a own 404 page where it mentions that you would need to select the email address for the Git author.

This however only seems to be the case for when you have more than one email address associated with your GitHub Account, which this PR changes, to mention that fact.

There is no issue associated with this PR, but a Discussion about it. See #2356 for complete context and info.

What's being changed:

The Reusable choose-commit-email.md is being edited to mention, that the dropdown only exists for when you have more than one verified email associated.

Check off the following:

@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Jan 13, 2021

Thanks @Andre601 for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Jan 13, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 21, 2021
@Andre601
Copy link
Copy Markdown
Contributor Author

Andre601 commented Jan 21, 2021

Still active. 👍

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 21, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 29, 2021
@Andre601
Copy link
Copy Markdown
Contributor Author

Andre601 commented Jan 29, 2021

👍

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 30, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
@Andre601
Copy link
Copy Markdown
Contributor Author

Andre601 commented Feb 13, 2021 •
edited
Loading

okay... Wow....
Why was it closed???

@Andre601
Copy link
Copy Markdown
Contributor Author

Andre601 commented Feb 13, 2021

@gracehop Stop wasting our time with this review spam. I will report you for it if you continue.

@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Feb 16, 2021

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛 I'm also reporting the approver internally!

@janiceilene janiceilene reopened this Feb 16, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
@chiedo chiedo added the waiting for review Issue/PR is waiting for a writer's review label Feb 17, 2021
megbird
megbird previously approved these changes Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had just one small suggestion you can easily incorporate if you'd like, but other than that, this PR looks great. Thank you SO much for the additional context in your original comment, it helped us verify that this was correct super fast so we were no longer blocking you ❤️

@Andre601 Andre601 dismissed stale reviews from megbird and ghost via d1f4952 February 26, 2021 22:32
Andre601 and others added 2 commits February 26, 2021 23:32
@Andre601 @megbird
Implement suggested change
d1f4952 
Co-authored-by: Meg Bird <megbird@github.com>
@megbird
Merge branch 'main' into patch-2
e37b34c
@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Mar 1, 2021
@janiceilene janiceilene merged commit 3d9c778 into github:main Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janiceilene janiceilene janiceilene approved these changes

+1 more reviewer

@megbird megbird megbird left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Andre601 @janiceilene @megbird @chiedo