Skip to content

Fix YAML in larger runner job example - #20375

Merged
sophietheking merged 2 commits into
github:mainfrom
StevenMaude:correct-larger-runner-job-yaml-syntax
Sep 8, 2022
Merged

Fix YAML in larger runner job example#20375
sophietheking merged 2 commits into
github:mainfrom
StevenMaude:correct-larger-runner-job-yaml-syntax

Conversation

@StevenMaude

@StevenMaude StevenMaude commented Sep 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

The syntax is not to the YAML specification.

Mappings use a colon and space (“: ”) to mark each key/value pair.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Correcting the syntax.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome

welcome Bot commented Sep 2, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions

github-actions Bot commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR to the GitHub Docs project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Sep 2, 2022
@github-actions

github-actions Bot commented Sep 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-github-hosted-runners/using-larger-runners.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21

cmwilson21 commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

@StevenMaude Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Sep 6, 2022
sophietheking
sophietheking approved these changes Sep 8, 2022
View reviewed changes

@sophietheking sophietheking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StevenMaude 👋 thank you so much for opening this PR and fixing the example, we really appreciate it. 💖

I'll get this merged for you! 🚀

@sophietheking sophietheking removed the waiting for review Issue/PR is waiting for a writer's review label Sep 8, 2022
@sophietheking
sophietheking merged commit 8618a59 into github:main Sep 8, 2022
@github-actions

github-actions Bot commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StevenMaude @cmwilson21 @sophietheking