Skip to content

Update the supported version of npm to v8#16707

Merged
mchammer01 merged 3 commits intogithub:mainfrom
jeffwidman:patch-2
Apr 4, 2022
Merged

Update the supported version of npm to v8#16707
mchammer01 merged 3 commits intogithub:mainfrom
jeffwidman:patch-2

Conversation

@jeffwidman
Copy link
Copy Markdown
Member

@jeffwidman jeffwidman commented Mar 31, 2022 •
edited
Loading

Support for npm v8 was added to Dependabot in dependabot/dependabot-core#4763.

Why:

Closes dependabot/dependabot-core#4936.

What's being changed:

Replacing v6 and v7 as officially supported versions with v8. v7 is no longer officially supported per the comments in dependabot/dependabot-core#4763, and if v7 isn't supported, v6 certainly isn't supported!

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jeffwidman
Update the supported version of npm to v8
89de77d 
Support for `npm` `v8` was added to Dependabot in dependabot/dependabot-core#4763.
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 31, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 31, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 31, 2022
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Mar 31, 2022

@jeffwidman
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@jeffwidman jeffwidman mentioned this pull request Mar 31, 2022
Closed
@mchammer01 mchammer01 self-requested a review April 4, 2022 09:56
@mchammer01
Copy link
Copy Markdown
Contributor

mchammer01 commented Apr 4, 2022

I'll review this!

@jurre
Copy link
Copy Markdown
Member

jurre commented Apr 4, 2022

Well actually (😬), we do still support v6 of npm because it still has a huge number of users. v7 is also kind of supported, in that, there are no breaking changes between v7 and v8 other than a deprecated node version, since we cannot determine wether someone is using v7 of v8 we perform the update using v8.

jurre
jurre reviewed Apr 4, 2022
View reviewed changes
mchammer01
mchammer01 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffwidman - thanks for your contribution ✨
I consulted with @jurre who told me that we were still supporting v6 and v7 so I've accepted his suggestion, and will merge this as soon as I can. You were right about v8 🙂

@mchammer01 mchammer01 enabled auto-merge April 4, 2022 10:07
@mchammer01 mchammer01 merged commit 14a518b into github:main Apr 4, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@jeffwidman jeffwidman deleted the patch-2 branch April 6, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jurre jurre jurre left review comments

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supported NPM versions doesn't list v8, despite v8 being used in the code

4 participants

@jeffwidman @ramyaparimi @mchammer01 @jurre