Skip to content

Commit f39c19e

Browse files
heiskrheiskr
authored
Update to Node 18 (#34001)
1 parent 4a6d3b4 commit f39c19e

18 files changed

+39
-37
lines changed

‎.devcontainer/Dockerfile‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.177.0/containers/javascript-node/.devcontainer/base.Dockerfile
1+
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.Dockerfile
22

3-
# [Choice] Node.js version: 16, 14, 12
4-
ARG VARIANT="16-buster"
3+
# [Choice] Node.js version
4+
ARG VARIANT="18-buster"
55
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
66

77
# [Optional] Uncomment this section to install additional OS packages.

‎.devcontainer/devcontainer.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"name": "docs.github.com",
66
"build": {
77
"dockerfile": "Dockerfile",
8-
// Update 'VARIANT' to pick a Node version: 12, 14, 16
9-
"args": { "VARIANT": "16" }
8+
// Update 'VARIANT' to pick a Node version
9+
"args": { "VARIANT": "18" }
1010
},
1111

1212
// Set *default* container specific settings.json values on container create.

‎.github/actions/node-npm-setup/action.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ runs:
1111
path: node_modules
1212
key: ${{ runner.os }}-node_modules-${{ hashFiles('package*.json') }}
1313

14-
- name: Setup node
14+
- name: Setup Node.js
1515
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
1616
with:
17-
node-version: '16.17.0'
17+
node-version-file: '.node-version'
1818
cache: npm
1919

2020
- name: Install dependencies

‎.github/workflows/azure-prod-build-deploy.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ jobs:
5555
# To prevent issues with cloning early access content later
5656
persist-credentials: 'false'
5757

58-
- name: Setup node
58+
- name: Setup Node.js
5959
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
6060
with:
61-
node-version: '16.17.0'
61+
node-version-file: '.node-version'
6262
cache: npm
6363

6464
- name: Clone docs-early-access

‎.github/workflows/azure-staging-build-deploy.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,10 @@ jobs:
7373
# Image tag is unique to each workflow run so that it always triggers a new deployment
7474
echo "DOCKER_IMAGE=${{ secrets.NONPROD_REGISTRY_SERVER }}/${{ env.IMAGE_REPO }}:${{ env.COMMIT_REF }}-${{ github.run_number }}-${{ github.run_attempt }}" >> $GITHUB_ENV
7575
76-
- name: Setup node
76+
- name: Setup Node.js
7777
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
7878
with:
79-
node-version: '16.17.0'
79+
node-version-file: '.node-version'
8080
cache: npm
8181

8282
- name: Clone docs-early-access

‎.github/workflows/browser-test.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ jobs:
5151
- name: Checkout
5252
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
5353

54-
- name: Setup Node
54+
- name: Setup Node.js
5555
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
5656
with:
57-
node-version: '16.17.0'
57+
node-version-file: '.node-version'
5858
cache: npm
5959

6060
- name: Install dependencies

‎.github/workflows/content-changes-table-comment.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ jobs:
5656
APP_NAME_SEED: ${{ secrets.PREVIEW_ENV_NAME_SEED }}
5757
run: .github/actions-scripts/get-preview-app-info.sh
5858

59-
- name: Setup Node
59+
- name: Setup Node.js
6060
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
6161
with:
62-
node-version: '16.17.0'
62+
node-version-file: '.node-version'
6363
cache: npm
6464

6565
- name: Install temporary dependencies

‎.github/workflows/docs-review-collect.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ jobs:
2222
- name: Check out repo content
2323
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
2424

25-
- name: Setup Node
25+
- name: Setup Node.js
2626
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
2727
with:
28-
node-version: '16.17.0'
28+
node-version-file: '.node-version'
2929
cache: npm
3030

3131
- name: Install dependencies

‎.github/workflows/os-ready-for-review.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ jobs:
4646
- name: Check out repo content
4747
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
4848

49-
- name: Setup Node
49+
- name: Setup Node.js
5050
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
5151
with:
52-
node-version: '16.17.0'
52+
node-version-file: '.node-version'
5353
cache: npm
5454

5555
- name: Install dependencies

‎.github/workflows/package-lock-lint.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ jobs:
2727
- name: Check out repo
2828
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
2929

30-
- name: Setup Node
30+
- name: Setup Node.js
3131
uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516
3232
with:
33-
node-version: '16.17.0'
33+
node-version-file: '.node-version'
34+
cache: npm
3435

3536
- name: Run check
3637
run: |

0 commit comments

Comments
 (0)