Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Conversation

@atmos
Copy link
Contributor

@atmos atmos commented Mar 11, 2014

I'm not exactly sure where these docs should go but they should go somewhere.

Fixes github/github-services#815

@pengwynn
Copy link
Contributor

Definitely the right page, but I think this deserves its own section titled "Receiving hooks" after "Delete a hook", before "Pubsubhubub". We could mention any server requirements and then just move the contents of this PR under that as "Request headers". Thoughts?

@atmos
Copy link
Contributor Author

atmos commented Mar 12, 2014

@pengwynn Awesome, I'll take that approach. I just wanted to get the discussion going.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, typos.

@atmos
Copy link
Contributor Author

atmos commented Mar 12, 2014

@kdaigle @pengwynn Any thoughts on filler for "Receiving Hooks."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a couple of small tweaks:

In order for GitHub to send Webhook payloads to your service, your server needs to be accessible from the Internet. We also highly suggest using SSL so that we can send encrypted payloads over HTTPS.

@pengwynn
Copy link
Contributor

:shipit:

atmos added a commit that referenced this pull request Mar 12, 2014
Document headers we send to payloads
@atmos atmos merged commit e1cbee2 into master Mar 12, 2014
@atmos atmos deleted the webhook-header-docs branch March 12, 2014 19:48
@atmos atmos restored the webhook-header-docs branch March 12, 2014 20:54
@gjtorikian gjtorikian deleted the webhook-header-docs branch May 8, 2015 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants