This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Changed comma to space in accordance with OAuth spec #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
|
Seems fine to me. |
Contributor
|
@edjiang Thanks for your contribution to developer.github.com! You rock! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OAuth 2 spec, it says that:
I tested this, and it seems like GitHub's OAuth implementation allows both spaces (to be spec compliant) and commas to delimit scopes. I think we should change the documentation so it matches the spec, and what people expect.
Otherwise the documentation will force people developing OAuth clients to make a deviation just for GitHub, even when it's not needed.