Edburns/dd 2855288 add smoke test to build and test#27
Merged
edburns merged 3 commits intogithub:mainfrom Mar 25, 2026
Merged
Conversation
…oke test a pre-condition for the build-test.yml. modified: .github/workflows/build-test.yml modified: .github/workflows/run-smoke-test.yml Signed-off-by: Ed Burns <edburns@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable “smoke test” workflow and wires it into the main Build & Test pipeline to validate a locally-built SDK via Copilot CLI before running the full Java test suite.
Changes:
- Enable
run-smoke-test.ymlto be invoked as a reusable workflow viaworkflow_call(with required secret wiring). - Add a new
smoke-testjob tobuild-test.ymland makejava-sdkdepend on it. - Switch
build-test.yml’s Java distribution tomicrosoft.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/run-smoke-test.yml |
Makes the smoke test workflow callable from other workflows and declares required secrets. |
.github/workflows/build-test.yml |
Adds a smoke-test job into CI and updates job ordering / Java distribution. |
modified: .github/workflows/build-test.yml
More absolutely excellent copilot review feedback.
> java-sdk now has needs: smoke-test, but the called workflow’s only job is gated by if: github.ref == 'refs/heads/main' (.github/workflows/run-smoke-test.yml:17). On pull_request and merge_group runs, smoke-test will be skipped, which will cause java-sdk to be skipped as well (no tests run). Consider either removing the hard dependency, or adding an explicit job if: ${{ always() && needs.smoke-test.result != 'failure' }} (or similar) so java-sdk still runs when smoke-test is skipped.
Signed-off-by: Ed Burns <edburns@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.