Skip to content

Fix container smoke-test workspace permissions #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devm33 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix container smoke-test workspace permissions #5310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion container/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ docker build -f container/Dockerfile --build-arg COPILOT_VERSION=1.0.105 -t copi
python3 container/smoke_test.py copilot-cli:local --version 1.0.105
```

The smoke test needs only Python 3 and Docker. It checks the container's configuration and a real client handshake with the running server. Add `--platform linux/arm64` or `--platform linux/amd64` to test a build for another architecture.
The smoke test needs only Python 3 and Docker. It checks the container's configuration, Git access to a bind-mounted repository owned by the host user, and a real client handshake with the running server. Add `--platform linux/arm64` or `--platform linux/amd64` to test a build for another architecture.

## Publishing

Expand Down
13 changes: 10 additions & 3 deletions container/smoke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,21 @@ def check_runtime_environment(target):

def check_git_workspace(target):
with tempfile.TemporaryDirectory(prefix="copilot-git-safe-") as workspace:
# The runtime UID needs access, while the host must own the files for cleanup.
os.chmod(workspace, 0o755)
volume = "%s:/home/copilot/workspace" % workspace
initialized = run_to_completion(
target,
["--user", "0:0", "--volume", volume, "--entrypoint", "git"],
["init", "--quiet", "/home/copilot/workspace"],
[
"--user", "%d:%d" % (os.getuid(), os.getgid()),
"--volume", "%s:/tmp/workspace" % workspace,
"--workdir", "/tmp/workspace",
"--entrypoint", "git",
],
["init", "--quiet"],
)
if initialized.returncode != 0:
raise Failure("could not initialize a root-owned workspace repository: %s" % initialized.stderr.strip())
raise Failure("could not initialize a host-owned workspace repository: %s" % initialized.stderr.strip())

result = run_to_completion(
target,
Expand Down
Loading