feat: add OUTPUT_FILENAME to customize markdown output#387
Open
vchrombie wants to merge 3 commits intogithub:mainfrom
Open
feat: add OUTPUT_FILENAME to customize markdown output#387vchrombie wants to merge 3 commits intogithub:mainfrom
vchrombie wants to merge 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for customizing the generated markdown report filename via a new OUTPUT_FILENAME environment variable (defaulting to contributors.md).
Changes:
- Added
OUTPUT_FILENAMEparsing (with default) toenv.get_env_vars(). - Wired the configured output filename into
contributors.pywhen writing the markdown report. - Updated tests and README to cover/document the new environment variable.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
env.py |
Adds OUTPUT_FILENAME env var handling and returns it from get_env_vars(). |
contributors.py |
Uses the returned output_filename when calling markdown.write_to_markdown(). |
test_env.py |
Extends env parsing tests to assert default and custom OUTPUT_FILENAME behavior. |
README.md |
Documents OUTPUT_FILENAME and updates job summary wording to be filename-agnostic. |
vchrombie
force-pushed
the
feat/output-filename-env-18
branch
from
30cb19a to
d4ff051
Compare
zkoppert
reviewed
Feb 3, 2026
Member
|
@vchrombie this looks great. I've got one documentation suggestion to help folks understand the default exists. Thanks for your PR!! |
Author
|
Thanks @zkoppert for the suggestion. |
Expose OUTPUT_FILENAME env var with default contributors.md, wire into markdown output, and document/test it. Signed-off-by: Venu Vardhan Reddy Tekula <venuvrtekula@gmail.com>
Use a job-level OUTPUT_FILENAME and reference it in content-filepath so examples stay in sync. Signed-off-by: Venu Vardhan Reddy Tekula <venuvrtekula@gmail.com>
vchrombie
force-pushed
the
feat/output-filename-env-18
branch
from
d5a635a to
cbb09ac
Compare
Author
|
I rebased the branch with the latest changes @zkoppert, could you please approve it to kick the ci checks? |
Co-authored-by: Zack Koppert <zkoppert@github.com> Signed-off-by: Venu Vardhan Reddy Tekula <venuvrtekula@gmail.com>
vchrombie
force-pushed
the
feat/output-filename-env-18
branch
from
c21a904 to
b226a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Expose OUTPUT_FILENAME env var with default contributors.md, wire into markdown output, and document/test it.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
bug,documentation,enhancement,infrastructure,maintenanceorbreaking