fix: Explicitly handle LINK_TO_PROFILE flag in markdown output#297
Closed
fix: Explicitly handle LINK_TO_PROFILE flag in markdown output#297
Conversation
Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] fix: LINK_TO_PROFILE Doesn't work as expected
Explicitly handle LINK_TO_PROFILE flag in markdown output
Jul 8, 2025
zkoppert
changed the title
Member
|
@copilot can you fix the failing GitHub action related to linting |
Member
|
@copilot can you add a test case for this logic |
Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>
Contributor
Author
Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>
Contributor
Author
Added a test case covering string |
Member
|
I'm thinking this points to a problem in the env code where we are not evaluating the string into the intended bool correctly. 👀 So I think the fix should be applied at the env.py level rather than trying to get the string to a bool right before we use it. |
…info Co-authored-by: zkoppert <6935431+zkoppert@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, non-empty string values for
LINK_TO_PROFILE(e.g."false") were treated as truthy, causing the username to always be prefixed (and effectively “linked”) even when the flag was intended to be false. This change normalizes thelink_to_profileparameter by converting it to a lowercase string and checking explicitly for"true". Only if the flag equals"true"(or booleanTrue) will the username be prefixed with@. Otherwise, it is rendered as plain text.link_to_profiletostr(...).lower()for comparison@usernameonly when the string equals"true"True/"True") are handled correctly"false"caseFixes #268.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
🚧 Copilot coding agent is using an experimental model for this task. Please take the time to report feedback with the 👍 or 👎 buttons.