Skip to content

Fix invalid devcontainer.json#11

Merged
joshaber merged 1 commit intogithub:mainfrom
Chuxel:main
Nov 17, 2022
Merged

Fix invalid devcontainer.json#11
joshaber merged 1 commit intogithub:mainfrom
Chuxel:main

Conversation

@Chuxel
Copy link
Copy Markdown
Contributor

@Chuxel Chuxel commented Nov 12, 2022

A number of these templates are missing an image reference, which means they won't work anywhere outside of Codespaces, including in the Dev Container GitHub Action.

If the goal is to use the "kitchen sink" image, all that is needed is a reference to the image. This will be slow in other scenarios, but won't fail like it would today.

@joshaber joshaber merged commit 8b008f0 into github:main Nov 17, 2022
Youngyoung1 pushed a commit to Youngyoung1/codespaces-react that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants