Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
43c1bea
Run npm install so have clear baseline
sampart Jun 24, 2020
b0af569
Add sinon package for mocking
sampart Jun 24, 2020
f4cf65c
Add a test that Octokit isn't used for local config
sampart Jun 24, 2020
153a598
Add a new function used to determine where to retrieve config from
sampart Jun 24, 2020
a19d19e
Add validation of remote config location, no retrieval yet
sampart Jun 25, 2020
56292b1
Reset mocks in test so they don't leak into later test
sampart Jun 25, 2020
32c9898
Fix regex
sampart Jun 25, 2020
388403b
Add a test that an Octokit request is made for remote config
sampart Jun 25, 2020
366d8a3
Retrieve remote configuration where specified
sampart Jun 26, 2020
9566d8c
Merge branch 'main' into support-remote-config
sampart Jun 26, 2020
f8c8794
Use new API client
sampart Jun 26, 2020
7c00663
Remove tests of internal function now its behaviour has been verified
sampart Jun 26, 2020
a66f2b0
Remove redundant comment
sampart Jun 26, 2020
51becd2
Bring error message method name inline with others
sampart Jun 26, 2020
0607771
Make remote config retrieval more robust
sampart Jun 26, 2020
ee4cc86
Merge branch 'main' into support-remote-config
sampart Jun 26, 2020
6afe410
Update node modules
sampart Jun 26, 2020
aad14bf
Remove `strategy: fail-fast`
robertbrignull Jun 29, 2020
ca76a2c
Add .DS_Store files from node module
sampart Jun 29, 2020
0e3f831
add analysis_key to status reports
robertbrignull Jun 29, 2020
e0299c3
Merge pull request #88 from github/fail-fast
robertbrignull Jun 29, 2020
04b2540
Update codeql bundle
robertbrignull Jun 30, 2020
4b37db7
Add integration test for retrieval of remote config
sampart Jun 30, 2020
25a0a6b
Use v2 of checkout action
sampart Jun 30, 2020
1bb294a
Combine integration tests for simplicity
sampart Jun 30, 2020
a52f1a5
Fix workflow name
sampart Jun 30, 2020
aa6c2c5
Fix URL in integration test
sampart Jun 30, 2020
c953f77
Merge pull request #92 from github/use-checkout-v2
sampart Jun 30, 2020
dc26788
Use right SHA in integration test
sampart Jun 30, 2020
260a93f
Merge branch 'main' into support-remote-config
sampart Jun 30, 2020
e2a8f32
Merge pull request #87 from github/support-remote-config
sampart Jun 30, 2020
4804679
Merge branch 'main' into codeql-bundle-20200630
robertbrignull Jun 30, 2020
de7ff14
Merge pull request #91 from github/codeql-bundle-20200630
robertbrignull Jul 1, 2020
580e603
Add development instructions to CONTRIBUTING.md
sampart Jul 1, 2020
dfed1f7
Point people at init/action.yml for node version
sampart Jul 2, 2020
55a6f9e
Merge pull request #94 from github/developer-docs
sampart Jul 2, 2020
eaf6649
Merge branch 'main' into analysis_key_status
robertbrignull Jul 2, 2020
72803c4
Merge pull request #90 from github/analysis_key_status
robertbrignull Jul 2, 2020
a0bf50c
Add details of who will merge (CONTRIBUTING.md)
sampart Jul 2, 2020
57a5771
Remove test builds section of PR template
sampart Jul 2, 2020
77e9a73
Merge branch 'main' into merge-help
sampart Jul 2, 2020
9bc459c
Merge pull request #95 from github/merge-help
sampart Jul 2, 2020
5d84e87
Merge branch 'main' into pr-template-test-builds
sampart Jul 2, 2020
8947510
Merge pull request #96 from github/pr-template-test-builds
sampart Jul 2, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
### Merge / deployment checklist

- Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
- [ ] CodeQL using init/analyze actions
- [ ] 3rd party tool using upload action
- [ ] Confirm this change is backwards compatible with existing workflows.
- [ ] Confirm the [readme](https://github.com/github/codeql-action/blob/master/README.md) has been updated if necessary.
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
with:
# Must fetch at least the immediate parents so that if this is
# a pull request then we can checkout the head of the pull request.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
exit 1
fi

multi-language-repo_test-custom-queries:
multi-language-repo_test-custom-queries-and-remote-config:
strategy:
fail-fast: false
matrix:
Expand All @@ -54,7 +54,7 @@ jobs:
- uses: ./../action/init
with:
languages: cpp,csharp,java,javascript,python
config-file: ./.github/codeql/custom-queries.yml
config-file: github/codeql-action/tests/multi-language-repo/.github/codeql/custom-queries.yml@${{ github.sha }}
- name: Build code
shell: bash
run: ./build.sh
Expand Down
21 changes: 20 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,32 @@ Contributions to this project are [released](https://help.github.com/articles/gi

Please note that this project is released with a [Contributor Code of Conduct][code-of-conduct]. By participating in this project you agree to abide by its terms.

## Development and Testing

Before you start, ensure that you have a recent version of node installed. You can see which version of node is used by the action in `init/action.yml`.

### Common tasks

* Transpile the TypeScript to JavaScript: `npm run build`. Note that the JavaScript files are committed to git.
* Run tests: `npm run test`. You’ll need to ensure that the JavaScript files are up-to-date first by running the command above.
* Run the linter: `npm run lint`.

### Running the action

To see the effect of your changes and to test them, push your changes in a branch and then look at the [Actions output](https://github.com/github/codeql-action/actions) for that branch. You can also exercise the code locally by running the automated tests.

### Integration tests

As well as the unit tests (see _Common tasks_ above), there are integration tests, defined in `.github/workflows/integration-testing.yml`. These are run by a CI check. Depending on the change you’re making, you may want to add a test to this file or extend an existing one.

## Submitting a pull request

1. [Fork][fork] and clone the repository
2. Create a new branch: `git checkout -b my-branch-name`
3. Make your change, add tests, and make sure the tests still pass
4. Push to your fork and [submit a pull request][pr]
5. Pat your self on the back and wait for your pull request to be reviewed and merged.
5. Pat yourself on the back and wait for your pull request to be reviewed and merged.
If you're a GitHub staff member, you can merge your own PR once it's approved; for external contributors, GitHub staff will merge your PR once it's approved.

Here are a few things you can do that will increase the likelihood of your pull request being accepted:

Expand Down
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ on:

jobs:
CodeQL-Build:

strategy:
fail-fast: false

# CodeQL runs on ubuntu-latest, windows-latest, and macos-latest
runs-on: ubuntu-latest

Expand Down
2 changes: 1 addition & 1 deletion init/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ inputs:
tools:
description: URL of CodeQL tools
required: false
default: https://github.com/github/codeql-action/releases/download/codeql-bundle-20200601/codeql-bundle.tar.gz
default: https://github.com/github/codeql-action/releases/download/codeql-bundle-20200630/codeql-bundle.tar.gz
languages:
description: The languages to be analysed
required: false
Expand Down
81 changes: 69 additions & 12 deletions lib/config-utils.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/config-utils.js.map

Large diffs are not rendered by default.

110 changes: 107 additions & 3 deletions lib/config-utils.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading