Second attempt to use --codescanning-config flag of CLI
#957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
approved these changes
Mar 1, 2022
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Similar to previous PR, which I approved. Looks fine to me.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #936, thus re-introducing the changes from #830.
The previous attempt to roll this out failed due to some users having invalid properties in their config files and the CLI version of the parsing not being tolerant to unknown fields. This was fixed in 2.8.2, so we can try this again now.
The first commit is a clean revert of the revert. The second commit bumps the version flag so we don't try to use the CLI to parse the config file if it is a version from before 2.8.2 which contained the aforementioned fix.
Merge / deployment checklist