Skip to content

Conversation

@sampart
Copy link
Contributor

@sampart sampart commented Jul 1, 2020

No description provided.

@sampart sampart requested a review from robertbrignull July 1, 2020 13:32
CONTRIBUTING.md Outdated

## Development and Testing

Before you start, you may want to ensure that you have a recent version of node installed. You can see which version of node is installed on the actions runners here: https://help.github.com/en/actions/reference/software-installed-on-github-hosted-runners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to include the node version (12) here, unless you are worried about it going out of date. I doubt this will change very quickly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also point to https://github.com/github/codeql-action/blob/main/init/action.yml which is the actual source of truth

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good plan, thanks! Done in dfed1f7

@sampart sampart merged commit 55a6f9e into main Jul 2, 2020
@sampart sampart deleted the developer-docs branch July 2, 2020 10:07
@github-actions github-actions bot mentioned this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants