Skip to content

Conversation

@robertbrignull
Copy link
Contributor

Setting strategy: fail-fast has no effect unless the workflow is run as part of a matrix build. It controls whether one matrix build failing causes other builds in that same matrix to be aborted. It has no effect within an individual run.

See https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast for more info.

I'm removing this from the suggested usage example because it is unnecessary and misleading.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

Copy link
Contributor

@chrisgavin chrisgavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I thought we already did this, but maybe that was just in the Actions template rather than the example in this repository.

@robertbrignull
Copy link
Contributor Author

I'm not sure. I also remember removing it.

@robertbrignull robertbrignull merged commit e0299c3 into main Jun 29, 2020
@robertbrignull robertbrignull deleted the fail-fast branch June 29, 2020 11:49
@github-actions github-actions bot mentioned this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants