Skip to content

Allow config files to be from a remote repository #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampart merged 24 commits into from
Jun 30, 2020
Merged

Allow config files to be from a remote repository #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
43c1bea
Run npm install so have clear baseline
sampart Jun 24, 2020
b0af569
Add sinon package for mocking
sampart Jun 24, 2020
f4cf65c
Add a test that Octokit isn't used for local config
sampart Jun 24, 2020
153a598
Add a new function used to determine where to retrieve config from
sampart Jun 24, 2020
a19d19e
Add validation of remote config location, no retrieval yet
sampart Jun 25, 2020
56292b1
Reset mocks in test so they don't leak into later test
sampart Jun 25, 2020
32c9898
Fix regex
sampart Jun 25, 2020
388403b
Add a test that an Octokit request is made for remote config
sampart Jun 25, 2020
366d8a3
Retrieve remote configuration where specified
sampart Jun 26, 2020
9566d8c
Merge branch 'main' into support-remote-config
sampart Jun 26, 2020
f8c8794
Use new API client
sampart Jun 26, 2020
7c00663
Remove tests of internal function now its behaviour has been verified
sampart Jun 26, 2020
a66f2b0
Remove redundant comment
sampart Jun 26, 2020
51becd2
Bring error message method name inline with others
sampart Jun 26, 2020
0607771
Make remote config retrieval more robust
sampart Jun 26, 2020
ee4cc86
Merge branch 'main' into support-remote-config
sampart Jun 26, 2020
6afe410
Update node modules
sampart Jun 26, 2020
ca76a2c
Add .DS_Store files from node module
sampart Jun 29, 2020
4b37db7
Add integration test for retrieval of remote config
sampart Jun 30, 2020
1bb294a
Combine integration tests for simplicity
sampart Jun 30, 2020
a52f1a5
Fix workflow name
sampart Jun 30, 2020
aa6c2c5
Fix URL in integration test
sampart Jun 30, 2020
dc26788
Use right SHA in integration test
sampart Jun 30, 2020
260a93f
Merge branch 'main' into support-remote-config
sampart Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/integration-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
exit 1
fi

multi-language-repo_test-custom-queries:
multi-language-repo_test-custom-queries-and-remote-config:
strategy:
fail-fast: false
matrix:
Expand All @@ -54,7 +54,7 @@ jobs:
- uses: ./../action/init
with:
languages: cpp,csharp,java,javascript,python
config-file: ./.github/codeql/custom-queries.yml
config-file: github/codeql-action/tests/multi-language-repo/.github/codeql/custom-queries.yml@${{ github.sha }}
- name: Build code
shell: bash
run: ./build.sh
Expand Down
81 changes: 69 additions & 12 deletions lib/config-utils.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/config-utils.js.map
View file
Open in desktop

Large diffs are not rendered by default.

110 changes: 107 additions & 3 deletions lib/config-utils.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading