Skip to content

Fix dotnet prompting for user input #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertbrignull merged 1 commit into from
Dec 6, 2021
Merged

Fix dotnet prompting for user input #833

robertbrignull merged 1 commit into from
Dec 6, 2021

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Dec 3, 2021 •
edited
Loading

A few CI checks are currently failing because dotnet is waiting for some user-input. e.g. https://github.com/github/codeql-action/runs/4381100962?check_suite_focus=true

This seems to be because of a change in the CodeQL CLI and how it handles dotnet under tracing in macos. This may get fixed in CodeQL but for now a workaround to get our CI working is to call dotnet restore when not traced by CodeQL so it can do it's first-time setup without interference.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@robertbrignull robertbrignull requested a review from a team as a code owner December 3, 2021 10:49
@robertbrignull robertbrignull changed the title Opt out of dotnet telemetry Deal with new dotnet version Dec 3, 2021
@robertbrignull robertbrignull force-pushed the robertbrignull/fix-dotnet branch 3 times, most recently from 7213e56 to c1b9717 Compare December 3, 2021 12:44
@robertbrignull robertbrignull force-pushed the robertbrignull/fix-dotnet branch from c1b9717 to f721f01 Compare December 6, 2021 09:43
edoardopirovano
edoardopirovano approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New change LGTM. I wonder whether it might be easier to have sync.py insert that call at the start of every workflow. Needn't be done in this PR, though - for now let's get this merged to unblock our tests.

@robertbrignull
Copy link
Contributor Author

robertbrignull commented Dec 6, 2021

New change LGTM. I wonder whether it might be easier to have sync.py insert that call at the start of every workflow. Needn't be done in this PR, though - for now let's get this merged to unblock our tests.

Thanks. I also think it would be better to just get it working for now. Having sync.py add that sounds nice, and would fit in with work on reducing the parallelism too.

@edoardopirovano
Copy link
Contributor

edoardopirovano commented Dec 6, 2021

Thanks. I also think it would be better to just get it working for now. Having sync.py add that sounds nice, and would fit in with work on reducing the parallelism too.

Agreed, I can look at doing that when I'm working on sync.py anyway. For now, let's get our CI working again 🙂

@robertbrignull
Copy link
Contributor Author

robertbrignull commented Dec 6, 2021

CI is passing so this looks like it works

@robertbrignull robertbrignull merged commit a82f53a into main Dec 6, 2021
@robertbrignull robertbrignull deleted the robertbrignull/fix-dotnet branch December 6, 2021 09:59
@robertbrignull robertbrignull changed the title Deal with new dotnet version Fix dotnet prompting for user input Dec 6, 2021
@github-actions github-actions bot mentioned this pull request Dec 6, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edoardopirovano edoardopirovano edoardopirovano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertbrignull @edoardopirovano