Include completed_at when action is aborted #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkappa
approved these changes
Jun 25, 2020
Contributor
alexkappa
left a comment
alexkappa
left a comment
There was a problem hiding this comment.
Sorry I've missed that, thanks for the fix!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got missed when reviewing, but we should include the
completed_atfield when an action is aborted so the status endpoint knows the action is ended and it should record how long it took.There's also another minor change to make on the other end to make this work, but I'm planning to do that in a PR I have open at the moment.
Merge / deployment checklist