Report that an action has been aborted on configuration failures #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2020 18:36
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
One typo that needs fixing, but otherwise looks basically there.
Could you run a test? Just push a new branch where you've intentionally made the config invalid and make sure it's behaving as expected.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for reporting with
status: abortedif a configuration failure has occurred.Dependencies
We shouldn't merge this PR until the
/repositories/{repository_id}/code-scanning/analysis/statusschema has been updated to allow for the new status.Merge / deployment checklist