Include matrix information in debug artifact name #809
Conversation
edoardopirovano
force-pushed
the
include-run-id
branch
from
ceffd9e to
93e19ee
Compare
edoardopirovano
force-pushed
the
include-run-id
branch
from
93e19ee to
375c147
Compare
edoardopirovano
changed the title
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
The uploaded artifacts look good. Is there any reason why we're not running these tests using windows?
| let suffix = ""; | ||
| const matrix = actionsUtil.getRequiredInput("matrix"); | ||
| if (matrix !== undefined && matrix !== "null") { | ||
| for (const entry of Object.entries(JSON.parse(matrix)).sort()) |
There was a problem hiding this comment.
How does sort work if the keys are arrays? I did a little test and it seems to work. Also, we only need this functionality to ensure our tests work, so even if the sorting is not stable, if our tests pass consistently, I'm not too worried.
There was a problem hiding this comment.
I believe the default way to compare two arrays in TypeScript is lexicographically. Since in this case the first element is the key of a JSON map, we know that all the arrays will differ in their first element (since the keys must be unique), so this is equivalent to sorting by the name of the key.
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Meant to approve the first time, but clicked the wrong button. :)
Only that the bash script that checks the result wouldn't work on Windows (I think). |
2 participants
Adds the contents of
matrixto the name of the debug artifact to avoid issues with clashing names in matrixed runs.