Skip to content

Make the temporary directory in tests a symlink #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertbrignull merged 1 commit into from
Jun 24, 2020
Merged

Make the temporary directory in tests a symlink #80

robertbrignull merged 1 commit into from
Jun 24, 2020

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Jun 23, 2020

We had a problem when the code was run under a directory that contained a symlink. It was fixed in #67

This PR hopes to avoid re-introducing a bug like that by making the directory returned by withTmpDir be a symlink to another directory. I've tested this by reverting #67 to reintroduce the bug and it fails in exactly the way we were seeing before.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

sampart
sampart approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@sampart sampart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, thanks.

@robertbrignull robertbrignull merged commit 04adf2b into main Jun 24, 2020
@robertbrignull robertbrignull deleted the symlinks_test branch June 24, 2020 09:23
@github-actions github-actions bot mentioned this pull request Jun 29, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sampart sampart sampart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sampart sampart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertbrignull @sampart