Skip to content

Conversation

@chrisgavin
Copy link
Contributor

It seems like we've ended up with a bit of a mixture of 2 and 4 space indentation in the codebase. After some discussion it seems like no one really minds which we use, so long as it's consistent. I've ended up picking two-space indentation since that seems to be the community preference.

I've added an editorconfig file which many editors will use to automatically determine the indentation style of new files.

I've also replaced the TSLint indent rule (which is broken) with ter-indent from the tslint-eslint-rules package. Ideally we should switch entirely from TSLint to ESLint, but it seems best to do that in a follow-up pull request.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions (N/A)
    • 3rd party tool using upload action (N/A)
  • Confirm this change is backwards compatible with existing workflows. (N/A)
  • Confirm the readme has been updated if necessary. (N/A)

@chrisgavin chrisgavin force-pushed the fix-indentation branch 2 times, most recently from 06ce9a0 to 6dcaced Compare June 23, 2020 13:41
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as the indentation is enforced by tslint, and therefore by the PR checks, then I'm happy. It looks like that is the case.

@chrisgavin chrisgavin merged commit b3c9d6f into main Jun 23, 2020
@chrisgavin chrisgavin deleted the fix-indentation branch June 23, 2020 14:40
@github-actions github-actions bot mentioned this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants