Call codeql.exe rather than codeql.cmd wrapper on Windows #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this. I'd heard codeql was switching to You're right the error is due to generated files. Run |
nickrolfe
force-pushed
the
nickrolfe/codeql.exe
branch
from
d3be680 to
852d99d
Compare
robertbrignull
approved these changes
Jun 23, 2020
Contributor
|
Sorry I think this now conflicts because we've normalised all the indentation. You'll have to merge in |
Contributor
Author
|
Thanks, I've merged |
Contributor
Author
|
@robertbrignull thanks for your help. Can you please merge? I don't have write access to this repository. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since CodeQL 2.0.2 (~6 months ago IIRC),
codeql.cmdhas been a trivial wrapper aroundcodeql.exeon Windows - it just forwards all arguments.Since we may want to remove it in the future, I think it makes sense for the action to stop using the wrapper. I assume we are using a relatively recent version of the CodeQL tools on Actions, that includes
codeql.exe.Sorry, I'm not sure how to test this, and I may not have made the change correctly - I just edited the two files where I found the
.cmdextension being added. One of them appears to be generated from the other, but I edited it manually.Merge / deployment checklist