Skip to content

Remove calls to fs.rmdirSync #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edoardopirovano merged 1 commit into from
Sep 23, 2021
Merged

Remove calls to fs.rmdirSync #751

edoardopirovano merged 1 commit into from
Sep 23, 2021

Conversation

@edoardopirovano
Copy link
Contributor

@edoardopirovano edoardopirovano commented Sep 23, 2021

Per https://nodejs.org/api/deprecations.html#DEP0147, the recursive option will no longer be supported on fs.rmdirSync soon - we need to switch to using fs.rmSync which is equivalent when using the recursive flag.

Merge / deployment checklist

  • [n/a] Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner September 23, 2021 08:27
@edoardopirovano edoardopirovano merged commit cd1b9df into github:main Sep 23, 2021
This was referenced Sep 27, 2021
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edoardopirovano @henrymercer