Add names to all pr-checks #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
approved these changes
Aug 24, 2021
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
Maybe JavaScript -> JS and CSharp -> C# for brevity. Other than that LGTM.
Contributor
|
...and we have to update our branch protection rules 😆 |
aeisenberg
force-pushed
the
aeisenberg/pr-check-names
branch
from
9fe2f7c to
88bc9ac
Compare
Contributor
Author
Good call. Done. |
Contributor
Author
That's not a PR, though, is it? |
Contributor
Author
|
Odd...does not seem to be showing the new names. |
aeisenberg
force-pushed
the
aeisenberg/pr-check-names
branch
from
88bc9ac to
1785bbb
Compare
Contributor
|
I think automerge won't work due to the checks changing name? |
Contributor
|
Yes, we have to change the Required checks in the branch protection rules in this repo's Settings page, to match the new check names. |
aeisenberg
force-pushed
the
aeisenberg/pr-check-names
branch
from
e567e17 to
e22a6cd
Compare
Contributor
Author
|
Going to need this PR to be force-pushed. It is getting confused because it is expecting all check names to pass, when they no longer exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to aid with debugging failing jobs. I tried to put the most important part of the name of each job first.
Merge / deployment checklist