Skip to content

Conversation

@github-actions
Copy link
Contributor

Merging 74f864b into v1

Conductor for this PR is @robertbrignull

Contains the following pull requests:

robertbrignull and others added 30 commits May 22, 2020 14:19
Validate sarif against schema before uploading
Usage of Jest was removed in #18
Remove jest config as tests use Ava now
Co-authored-by: Alex Kalyvitis <1204095+alexkappa@users.noreply.github.com>
Add simple instructions for sending repository dispatch event
Add matrix input to init action
Before this change, config-utils.ts › load non-empty input was failing on Mac with:

The configuration file "/var/folders/gx/y8v1507s29d97m1r_5kq0s000000gn/T/codeql-action-oum66d/input" is invalid: property "queries.uses" is invalid as the local path "" is outside of the repository

The reason is that the tmp directory (which is where the config file was put by the test) was a symlink.
Configure VSCode to ignore transpiled JavaScript
Ensure config path comparisons don't fail where workspace path is a symlink
@robertbrignull
Copy link
Contributor

I've had a look through the PRs again and I think this is good to merge. Everything here is safe to go into the v1 branch.

Probably the change most likely to cause issues is #39, but this is only moving errors further up the pipeline so they're more visible. The analysis would still have failed. Also the changes made in #61 should have helped avoid this.

@robertbrignull robertbrignull merged commit 7970d85 into v1 Jun 22, 2020
@robertbrignull robertbrignull deleted the update-v1-74f864b branch June 22, 2020 09:28
@robertbrignull robertbrignull mentioned this pull request Jun 22, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants