Skip to content

Reduce the number of PR checks that are run on push #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrymercer merged 1 commit into from
Aug 11, 2021
Merged

Reduce the number of PR checks that are run on push #700

henrymercer merged 1 commit into from
Aug 11, 2021

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Aug 11, 2021

If we're running on push, then we can reintroduce the logic that skips running with tools: latest when it would be the same as running with tools: null.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer force-pushed the henrymercer/reduce-num-pr-check-jobs-on-push branch from 13ca0e2 to 4eeb458 Compare August 11, 2021 15:19
@henrymercer henrymercer marked this pull request as ready for review August 11, 2021 15:23
@henrymercer henrymercer requested a review from a team as a code owner August 11, 2021 15:23
edoardopirovano
edoardopirovano approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrymercer henrymercer enabled auto-merge August 11, 2021 15:35
adityasharad
adityasharad approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions.

@henrymercer henrymercer disabled auto-merge August 11, 2021 15:36
@henrymercer
Reduce the number of PR checks that are run on push
b19f1f9 
If we're running on push, then we can reintroduce the logic that skips
running with `tools: latest` when it would be the same as running with
`tools: null`.
@henrymercer henrymercer force-pushed the henrymercer/reduce-num-pr-check-jobs-on-push branch from 4eeb458 to b19f1f9 Compare August 11, 2021 16:27
@henrymercer henrymercer merged commit 962925a into main Aug 11, 2021
@henrymercer henrymercer deleted the henrymercer/reduce-num-pr-check-jobs-on-push branch August 11, 2021 17:11
@github-actions github-actions bot mentioned this pull request Aug 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityasharad adityasharad adityasharad approved these changes

+1 more reviewer

@edoardopirovano edoardopirovano edoardopirovano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@henrymercer @edoardopirovano @adityasharad