Skip to content

Conversation

@sampart
Copy link
Contributor

@sampart sampart commented Jun 17, 2020

Before:

image

After:

image

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@sampart sampart requested a review from robertbrignull June 17, 2020 13:58
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and I think it's fine to include this as there is precedent and the vast majority of us here are using vscode for development on this repo.

@sampart sampart merged commit dc4009c into master Jun 17, 2020
@sampart sampart deleted the ignore-javascript branch June 17, 2020 15:14
@github-actions github-actions bot mentioned this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants