Update CodeQL link in README #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Thanks for spotting the name update!
For the second change, GitHub uses US style for punctuation and quotation marks. See https://docs.microsoft.com/en-us/style-guide/punctuation/quotation-marks. I agree this makes some cases look a odd to non-Americans. Would you mind removing that change from this PR?
Contributor
Author
|
Sure, have changed it now. Also thanks for linking to the style-guide and explaining the rationale, I wasn't aware that this is the US style. |
robertbrignull
approved these changes
Jun 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QL was moved from
semmle/qltogithub/codeql.