Skip to content

Update v1 branch #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertbrignull merged 11 commits into from
Jun 4, 2020
Merged

Update v1 branch #53

robertbrignull merged 11 commits into from
Jun 4, 2020

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Jun 3, 2020

It's not long since we did the last update to the v1 branch, but I'd like to get this change out there as soon as possible as it has been a hotly requested feature. This update will only contain #45.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

anaarmas
anaarmas approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@anaarmas anaarmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #45 it sounds like this has been tested enough.

@robertbrignull robertbrignull merged commit a30f854 into v1 Jun 4, 2020
@robertbrignull robertbrignull deleted the update-v1 branch June 8, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anaarmas anaarmas anaarmas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Daverlo Daverlo

@anaarmas anaarmas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robertbrignull @anaarmas @Daverlo