Skip to content

Fix parsing of path-ignore field #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aibaars merged 1 commit into from
Apr 29, 2020
Merged

Fix parsing of path-ignore field #5

aibaars merged 1 commit into from
Apr 29, 2020

Conversation

@aibaars
Copy link
Contributor

@aibaars aibaars commented Apr 29, 2020 •
edited
Loading

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in otehr repos!
    • CodeQL using init/finish actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@aibaars aibaars marked this pull request as ready for review April 29, 2020 11:14
@greysteil greysteil mentioned this pull request Apr 29, 2020
Merged
@aibaars aibaars requested a review from Daverlo April 29, 2020 11:16
@aibaars aibaars merged commit 72f1ed0 into master Apr 29, 2020
XhmikosR
XhmikosR reviewed Apr 29, 2020
View reviewed changes
lib/config-utils.js
}
const pathsIgnore = parsedYAML['paths-ignore'];
if (pathsIgnore && queries instanceof Array) {
if (pathsIgnore && pathsIgnore instanceof Array) {
Copy link
Contributor

@XhmikosR XhmikosR Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aibaars Maybe Array.isArray is better here?

@chrisgavin chrisgavin deleted the aibaars-patch-1 branch September 2, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Daverlo Daverlo Daverlo approved these changes

+1 more reviewer

@XhmikosR XhmikosR XhmikosR left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aibaars @XhmikosR @Daverlo