introduce new syntax for built-in query suites #45
Conversation
src/config-utils.ts
Outdated
| } | ||
|
|
||
| // The set of acceptable values for built-in suites from the codeql bundle | ||
| const builtinSuites = ['security-experimental', 'security-and-quality'] as const; |
There was a problem hiding this comment.
| const builtinSuites = ['security-experimental', 'security-and-quality'] as const; | |
| const builtinSuites = ['security-extended', 'security-and-quality'] as const; |
Let's go with security-extended instead, since it's not strictly experimental, but just more queries of varied quality. Thanks!
There was a problem hiding this comment.
I should have said the suite names in this PR were mostly just a placeholder as I thought that decision was still being made. I'll update this once we know what they'll be.
chrisgavin
left a comment
chrisgavin
left a comment
There was a problem hiding this comment.
Thanks for improving the input validation. 👍 This looks good once we've settled on the right suite names.
|
Running all the new suites in all languages at https://github.com/Anthophila/multi-language-test/runs/727232837 |
robertbrignull
force-pushed
the
suite_syntax
branch
from
e752439 to
07e22b1
Compare
|
Note this change is technically not backwards compitable for anyone using the unadvised |
|
|
In order to avoid the command line length issue, I've changed it to create a temporary query suite file that just lists the queries. I can't find the comment or email anymore now but I think @Daverlo and @hmakholm had a discussion recently suggesting this plan for another reason, so I hope this is not a bad move to make. Also note, the issue with the command line length on windows was already there if somebody tried to run a lot of queries. Adding this new syntax just makes it easier to trigger. |
|
Thanks for putting this one together @robertbrignull ! I've tagged our friends in docs to get this on their radar too. |
Looks good to me. |
|
I think this has been tested enough. I manually ran all query suites for all languages, and the integration tests pass. Right now there's not much more we can do. |
Tightens up the rules on relative paths in the config file, and introduces new options to reference suites from the codeql bundle.
This PR is pending the decision on the exact names of the suites, and actually introducing those suites into the codeql bundle.
Merge / deployment checklist