Update v1 branch to latest master #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
Note in readme about go analysis in macos-latest
Use tmp dir for external queries test
Create undeclared-action-input.ql
Add PR check to remove npm absolute paths
provide a better error when codeql fails to download
Swap the `jest` testing framwork for `ava`
upload ref in status report
Enable source maps
Use the full amount of memory when running queries.
Log some simple stats about the upload
Emit an error if upload happens twice
Add tests for config-utils
Contributor
Author
|
I've done some manual testing of this on a couple of repositories. Probably the only thing I tested that wasn't also done by the integration tests was that I tried the autobuilder on a non-trivial C project. I think this is good to go and we're ok to push master to the v1 branch. |
Daverlo
approved these changes
May 22, 2020
Contributor
Daverlo
left a comment
Daverlo
left a comment
There was a problem hiding this comment.
I see that you ran the analysis on git and electron. I've run it on cognito-js and it succeded: https://github.com/Anthophila/amazon-cognito-js/runs/699129405?check_suite_focus=true
I think it is safe to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bring the v1 branch up to date with the latest change and master and roll out a number of improvements that have happened in the past couple of weeks.
@anaarmas, @Daverlo, @joshhale, I suggest we all do some manual testing of this to make sure it's working as expected. I'll then aim to merge it early tomorrow UK time so we'll have the whole working day to be available. I don't want to merge this late on Friday.
Merge / deployment checklist