Skip to content

Log some simple stats about the upload #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertbrignull merged 2 commits into from
May 18, 2020
Merged

Log some simple stats about the upload #38

robertbrignull merged 2 commits into from
May 18, 2020

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented May 15, 2020

Log a few simple stats about the upload we're making, as requested by @marcogario. The logging is done at debug level so most users won't see it, but it could be useful for us.

This makes the assumption that the sarif file is valid and will fail if it isn't, but I intend to introduce validation of the sarif files imminently in another PR.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@robertbrignull robertbrignull mentioned this pull request May 15, 2020
Merged
4 tasks
marcogario
marcogario approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@marcogario marcogario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertbrignull
Copy link
Contributor Author

robertbrignull commented May 18, 2020

Here are some demos:

##[debug]Raw upload size: 130372 bytes
##[debug]Base64 zipped upload size: 15640 bytes
##[debug]Number of results in upload: 25

##[debug]Raw upload size: 319626 bytes
##[debug]Base64 zipped upload size: 19856 bytes
##[debug]Number of results in upload: 752

@robertbrignull robertbrignull merged commit 886b7d3 into master May 18, 2020
@robertbrignull robertbrignull deleted the upload_stats branch May 18, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marcogario marcogario marcogario approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marcogario marcogario

@Daverlo Daverlo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robertbrignull @marcogario @Daverlo