Support find .sarif files recursively #352
Conversation
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Thanks for implementing this. The implementation is nice and simple and looks good to me.
The only thing I was worried about was if we'd get into loops with symbolic links, but looking at the documentation it looks like it'll be fine, and I even gave it a try locally and it was fine.
I think we could add a unit test of this but rather than delaying this PR it'll probably be easiest to merge now and I'll add a quick test.
ghost
mentioned this pull request
|
The workings of this feature is not documented in the action.yml nor readme, despite the checkmark for it. Some examples would be helpful. For example, this recursive implementation does only work on folder names and not file names. |
Can you be more specific? You can specify a directory (which gets searched recursively for sarif files or a single file. Is there a feature you are looking for, but is not implemented here? Or are you just seeking clarity on the behaviour? |
4 participants
This addresses #220 by recursively calling
fs.readdirSync()Merge / deployment checklist