Skip to content

Prevent accidental analysis of the get-pip.py script. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisgavin merged 1 commit into from
Dec 22, 2020
Merged

Prevent accidental analysis of the get-pip.py script. #349

chrisgavin merged 1 commit into from
Dec 22, 2020

Conversation

@chrisgavin
Copy link
Contributor

@chrisgavin chrisgavin commented Dec 22, 2020

It seems like in some cases this script gets analyzed. We can either remove it after running it, or just not save it at all.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@chrisgavin chrisgavin mentioned this pull request Dec 22, 2020
Merged
2 tasks
@chrisgavin
Copy link
Contributor Author

chrisgavin commented Dec 22, 2020 •
edited
Loading

I've verified that this does fix the extraction of get-pip.py. The Action previously output these lines which are gone when running it with this branch:

  [2020-12-22 14:31:21] [build] [INFO] [2] Extracted file /home/runner/work/py2004/py2004/get-pip.py in 774ms
  [2020-12-22 14:31:21] [build] [INFO] [2] Extracted file /home/runner/work/py2004/py2004/get-pip.py in 774ms

(Also a bunch of other imports of get-pip.py are no longer extracted too! 🎉)

@chrisgavin chrisgavin merged commit 094554c into main Dec 22, 2020
@chrisgavin chrisgavin deleted the prevent-accidental-analysis-of-get-pip branch December 22, 2020 14:48
@github-actions github-actions bot mentioned this pull request Dec 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cbraynor cbraynor cbraynor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisgavin @cbraynor